Log unexpected exceptions in exception view #5820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few of these don't produce any logging in local development making debugging them tricky. Added an explicit logging here. Not sure if this would duplicate logging in a production environment. If that the case we can change this from `exception` to `debug`.
marcospri
commented
Nov 13, 2023
| @@ -94,6 +98,7 @@ def serializable_error(self): | |||
|
|
|||
| @exception_view_config(context=Exception) | |||
| def error(self): | |||
| LOG.exception("Unexpected error %s", type(self.exception)) | |||
There was a problem hiding this comment.
These are completely silent in the local logs. Or at least some of them
acelaya
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of these don't produce any logging in local development making debugging them tricky.
Added an explicit logging here. Not sure if this would duplicate logging in a production environment. If that the case we can change this from
exceptiontodebug.